Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add await on switchNetwork #3895

Merged
merged 3 commits into from
Feb 21, 2025
Merged

fix: add await on switchNetwork #3895

merged 3 commits into from
Feb 21, 2025

Conversation

magiziz
Copy link
Contributor

@magiziz magiziz commented Feb 21, 2025

Description

We didn't add await in switchNetwork

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 21, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: efc038b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 19 packages
Name Type
@reown/appkit-adapter-bitcoin Patch
@reown/appkit-adapter-ethers5 Patch
@reown/appkit-adapter-ethers Patch
@reown/appkit-adapter-solana Patch
@reown/appkit-utils Patch
@reown/appkit Patch
@reown/appkit-adapter-wagmi Patch
@reown/appkit-cdn Patch
@reown/appkit-cli Patch
@reown/appkit-common Patch
@reown/appkit-core Patch
@reown/appkit-experimental Patch
@reown/appkit-polyfills Patch
@reown/appkit-scaffold-ui Patch
@reown/appkit-siwe Patch
@reown/appkit-siwx Patch
@reown/appkit-ui Patch
@reown/appkit-wallet Patch
@reown/appkit-wallet-button Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Feb 21, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
appkit-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 21, 2025 0:54am
appkit-ethers5-bera ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 21, 2025 0:54am
appkit-laboratory ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 21, 2025 0:54am
next-wagmi-solana-bitcoin-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 21, 2025 0:54am
10 Skipped Deployments
Name Status Preview Comments Updated (UTC)
appkit-basic-ep ⬜️ Ignored (Inspect) Feb 21, 2025 0:54am
appkit-basic-ep-example ⬜️ Ignored (Inspect) Feb 21, 2025 0:54am
appkit-basic-example ⬜️ Ignored (Inspect) Feb 21, 2025 0:54am
appkit-basic-sign-client-example ⬜️ Ignored (Inspect) Feb 21, 2025 0:54am
appkit-basic-up-example ⬜️ Ignored (Inspect) Feb 21, 2025 0:54am
appkit-nansen-demo ⬜️ Ignored (Inspect) Visit Preview Feb 21, 2025 0:54am
appkit-vue-solana ⬜️ Ignored (Inspect) Feb 21, 2025 0:54am
appkit-wagmi-cdn-example ⬜️ Ignored (Inspect) Feb 21, 2025 0:54am
ethereum-provider-wagmi-example ⬜️ Ignored (Inspect) Visit Preview Feb 21, 2025 0:54am
vue-wagmi-example ⬜️ Ignored (Inspect) Feb 21, 2025 0:54am

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 21, 2025 •
edited
Loading

Warnings
⚠️ File packages/appkit/src/client.ts contains a KEY or SECRET
⚠️ File packages/appkit/tests/client/public-methods.test.ts contains a KEY or SECRET

Generated by 🚫 dangerJS against efc038b

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 21, 2025 •
edited
Loading

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 72.28% 23076 / 31924
🔵 Statements 72.28% 23076 / 31924
🔵 Functions 62.21% 1849 / 2972
🔵 Branches 81.02% 3987 / 4921
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/appkit/src/client.ts 59.93% 83.43% 76.8% 59.93% 182-183, 215-216, 236-237, 240-241, 256-259, 262-265, 285-286, 289-290, 306-340, 343-352, 367-368, 618-619, 622-625, 628-629, 632-633, 636-637, 640-641, 648-652, 717-727, 736-761, 768-771, 798-799, 813-814, 823-824, 827-828, 833-834, 858-859, 886-892, 918-929, 932-968, 971-976, 992-996, 1009-1020, 1023-1042, 1045-1051, 1054-1064, 1067-1079, 1082-1084, 1087-1089, 1092-1094, 1097-1099, 1102-1109, 1114-1172, 1180-1192, 1203-1217, 1220-1227, 1230-1241, 1244-1250, 1255, 1259, 1274, 1287-1288, 1296-1299, 1302-1305, 1308-1314, 1324-1325, 1357-1373, 1385-1388, 1392, 1408-1418, 1427-1428, 1434-1439, 1445-1463, 1469-1476, 1480-1495, 1513-1523, 1526-1605, 1608-1628, 1646, 1662-1663, 1669, 1671-1687, 1692, 1704, 1742-1749, 1751-1762, 1765-1773, 1811-1814, 1821-1827, 1834-1835, 1840-1841, 1880-1881, 1894-1895, 1900-1901, 1903-1904, 1909-1912, 1923-1924, 1963-1967, 1992-1993, 2017-2018, 2048-2049, 2053-2054, 2152-2158, 2191-2196, 2198-2208, 2210, 2212-2224, 2226-2240, 308-344
Generated in workflow #9735 for commit efc038b by the Vitest Coverage Report Action

tomiir
tomiir approved these changes Feb 21, 2025
View reviewed changes
Copy link
Collaborator

@tomiir tomiir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need a test for this?

@magiziz magiziz merged commit 8d2a81f into main Feb 21, 2025
30 checks passed
@magiziz magiziz deleted the fix/switch-network-await branch February 21, 2025 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomiir tomiir tomiir approved these changes

@svenvoskamp svenvoskamp svenvoskamp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@magiziz @tomiir @svenvoskamp